Added proxy and ZFS drives.

- Made the qemu-agent content in the cloud-init config to be controlled
  by a 'install-qemu-agent' flag.

.gitignore

@@ -44,6 +44,7 @@ terraform.rc
 ################################################################################
 
 k8s-key*
+*admin-key*
 STARTHERE
 inventory
 

cloud_init.cfg

@@ -26,6 +26,10 @@ chpasswd:
 hostname: ${hostname}
 fqdn: ${hostname}
 
+package_update: true
+package_upgrade: true
+package_reboot_if_required: true
+
 %{ if install-qemu-agent }
 packages:
   # This are only necessary for libvirt.

example.tfvars

@@ -19,17 +19,6 @@ node-vcpus = 2
 # 12 GiB
 # libvirt-node-disk-size = "${12 * 1073741824}"
 
-################################################################################
-# AWS EC2 instance types
-################################################################################
-
-# 1 GiB, 1 vcpu, only one that is free.
-# This one won't work with k8s because it requires at least 2 vcpus.
-aws-ec2-instance-type = "t2.micro"
-
-# 4 GiB, 2 vcpus
-# aws-ec2-instnce-type = "t2.medium"
-
 ################################################################################
 # AWS images (AMIs)
 ################################################################################

get-vm-ips.sh

@@ -22,6 +22,10 @@ VM_NAME_PREFIX="$(
         tail -n 1 | \
         sed 's/^.*=\s*"\(.*\)"/\1/g')"
 
+PUBLIC_IP_OUTPUT="groups_hostnames_ips"
+PRIVATE_IP_OUTPUT="groups_hostnames_private_ips"
+IP_TYPE="$PRIVATE_IP_OUTPUT"
+
 # This command stores the output data in the format below.
 # [
 #   {
@@ -48,7 +52,7 @@ VM_NAME_PREFIX="$(
 #   }
 # ]
 DATA="$(terraform show -json | \
-    jq '.values.outputs.groups_hostnames_ips.value | to_entries |
+    jq '.values.outputs.'"$IP_TYPE"'.value | to_entries |
         map({group: .key, vms:.value | to_entries |
         map({hostname:.key,ip:.value})})')"
 
@@ -80,13 +84,15 @@ for GROUP in $ANS_GROUPS; do
     # HOSTNAME1=0.0.0.0
     # HOSTNAME2=0.0.0.0
     VARS="$(
-        echo $DATA | \
+        echo -n $DATA | \
             jq '.[] | select(.group=="'"$GROUP"'") | .vms[] | 
                 "\(.hostname)=\(.ip)"' | \
             sed 's/"//g' | \
             sed "s/$VM_NAME_PREFIX-//g" | \
             sed 's/-/_/g'
         )"
-    # Print the contents of $VARS converted to uppercase.
+    # Print the contents of $VARS converted to uppercase. If it's not expty.
-    echo "${VARS^^}"
+    if [ ! -z "$VARS" ]; then
+        echo "${VARS^^}"
+    fi
 done

main.tf

@@ -1,14 +1,53 @@
 
 locals {
+  k8s-subnets-ids = [
+    # module.aws-network-from-scratch.subnet.id,
+    module.aws-network-existing.subnet-by-name["subnet_1"].id,
+    module.aws-network-existing.subnet-by-name["subnet_3"].id,
+  ]
+  nfs-subnets = [
+    # module.aws-network-from-scratch.subnet,
+    module.aws-network-existing.subnet-by-name["subnet_4"],
+  ]
+  aws-security-group-id = module.aws-network-existing.default-sg.id
+  # aws-security-group-id = module.aws-network-from-scratch.default-security-group.id
   nodes-config = {
-    "master" = {
+    "k8s-master" = {
-      base-image = var.centos8-ami
+      base-image = var.ubuntu-ami
+      aws-ec2-type = var.t2-medium-4gib-2vcpu
+      subnet-ids = local.k8s-subnets-ids
+      num = 0
+    },
+    "k8s-worker" = {
+      base-image = var.ubuntu-ami
+      aws-ec2-type = var.t2-medium-4gib-2vcpu
+      subnet-ids = local.k8s-subnets-ids
+      num = 0
+    },
+    "ansible-test" = {
+      base-image = var.ubuntu-ami
+      aws-ec2-type = var.t2-micro-1gib-1vcpu
+      # subnet-ids = [module.aws-network-from-scratch.subnet.id]
+      subnet-ids = [module.aws-network-existing.subnet-by-name["subnet_2"].id]
+      num = 0
+    },
+    "nfs" = {
+      base-image = var.ubuntu-ami
+      aws-ec2-type = var.t2-micro-1gib-1vcpu
+      # subnet-ids = [module.aws-network-from-scratch.subnet.id]
+      subnet-ids = [module.aws-network-existing.subnet-by-name["subnet_4"].id]
+      num = 1
+      num-disks = 1
+      disk-size = 10
+    },
+    "proxy" = {
+      base-image = var.ubuntu-ami
+      aws-ec2-type = var.t2-micro-1gib-1vcpu
+      # subnet-ids = [module.aws-network-from-scratch.subnet.id]
+      subnet-ids = [module.aws-network-existing.subnet-by-name["subnet_4"].id]
+      private-ips = [var.aws-proxy-private-ip]
       num = 1
     },
-    "worker" = {
-      base-image = var.centos8-ami
-      num = 2
-    }
   }
   install-qemu-agent = false
 }
@@ -59,7 +98,10 @@ module "cloud-init-config" {
 # }
 
 module "aws-network-existing" {
-  source = "./modules/aws-network-existing"
+  source                      = "./modules/aws-network-existing"
+  default-vpc-name            = var.aws-existing-vpc-name
+  default-security-group-name = var.aws-existing-sg-name
+  existing-subnet-names       = var.aws-existing-subnet-names
 }
 
 ################################################################################
@@ -74,16 +116,41 @@ resource "aws_key_pair" "key" {
   }
 }
 
+resource "aws_ebs_volume" "zfs" {
+  # TODO REM look at types.
+  availability_zone = local.nfs-subnets[0].availability_zone
+  size = local.nodes-config["nfs"].disk-size
+  encrypted = true
+  count = local.nodes-config["nfs"].num-disks
+  tags = {
+    Name = "zfs-disk-${count.index}"
+  }
+}
+
+resource "aws_volume_attachment" "mount-nfs-volume" {
+  device_name = "/dev/sd${element(var.aws-zfs-drive-letters, count.index)}"
+  instance_id = module.nodes["nfs"].nodes[0].id
+  count = local.nodes-config["nfs"].num-disks
+  volume_id = element(aws_ebs_volume.zfs, count.index).id
+}
+
+output "zfs-drive-letters" {
+  value = aws_volume_attachment.mount-nfs-volume.*.device_name
+}
+
 module "nodes" {
   for_each           = local.nodes-config
   source             = "./modules/aws-nodes"
+  ec2-instance-type  = each.value.aws-ec2-type
   ami                = each.value.base-image
-  ec2-instance-type  = var.aws-ec2-instance-type
+  subnet-ids         = each.value.subnet-ids
-  subnet-id          = module.aws-network.subnet.id
+  private-ips        = try(each.value.private-ips, [])
-  security-group-ids = [module.aws-network.default-security-group.id]
+  security-group-ids = [local.aws-security-group-id]
   user-datas         = lookup(module.cloud-init-config, each.key, null).user-datas
   num-nodes          = each.value.num
   name-prefix        = "${var.vm-name-prefix}-${each.key}"
+  # TODO add a input for the key so that it will show up as the key in the aws
+  # console.
 }
 
 ################################################################################
@@ -127,8 +194,14 @@ module "nodes" {
 # end libvirt
 ################################################################################
 
-# This will output a map of group => [{hostname, ip}].
+# This will outpus a map of group => [{hostname, ip}].
 # TODO A 'names' output needs to be added to libvirt.
 output "groups_hostnames_ips" {
   value = { for type, node in module.nodes : type => zipmap(node.names, node.ips) }
 }
+
+# This will outpus a map of group => [{hostname, private_ip}].
+# TODO Figure out how what to do about private_ips for libvirt.
+output "groups_hostnames_private_ips" {
+  value = { for type, node in module.nodes : type => zipmap(node.names, node.private_ips) }
+}

modules/aws-amis/main.tf

@@ -1,31 +1,52 @@
 locals {
   amis = {
     amzn2 = {
-      owner-id = "137112412989"
+      # us-east-2
+      # owner-id = "137112412989"
+      # us-gov-west-1
+      owner-id = "045324592363"
       name = "amzn2-ami-hvm-2*x86_64-gp2"
     },
     ubuntu = {
-      owner-id = "099720109477"
+      # us-east-2
+      # owner-id = "099720109477"
+      # us-gov-west-1
+      owner-id = "513442679011"
       name = "ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-*"
     },
-    centos7 = {
+    # centos7 = {
-      owner-id = "125523088429"
+    #   # us-east-2
-      name = "CentOS 7.*x86_64"
+    #   # owner-id = "125523088429"
-    },
+    #   # us-gov-west-1
-    centos8 = {
+    #   # owner-id = THERE IS NO CENTOS7 IMAGE in us-gov-west-1!!
-      owner-id = "125523088429"
+    #   name = "CentOS 7.*x86_64"
-      name = "CentOS 8.*x86_64"
+    # },
-    },
+    # centos8 = {
-    arch = {
+    #   # us-east-2
-      owner-id = "093273469852"
+    #   # owner-id = "125523088429"
-      name = "arch-linux-lts-hvm*x86_64-ebs"
+    #   # us-gov-west-1
-    },
+    #   # owner-id = THERE IS NO CENTOS8 IMAGE in us-gov-west-1!!
+    #   name = "CentOS 8.*x86_64"
+    # },
+    # arch = {
+    #   # us-east-2
+    #   # owner-id = "093273469852"
+    #   # us-gov-west-1
+    #   # owner-id = THERE IS NO ARCH IMAGE in us-gov-west-1!!
+    #   name = "arch-linux-lts-hvm*x86_64-ebs"
+    # },
     rhel7 = {
-      owner-id = "309956199498"
+      # us-east-2
+      # owner-id = "309956199498"
+      # us-gov-west-1
+      owner-id = "219670896067"
       name = "RHEL-7.*HVM*x86_64*GP2"
     },
     rhel8 = {
-      owner-id = "309956199498"
+      # us-east-2
+      # owner-id = "309956199498"
+      # us-gov-west-1
+      owner-id = "219670896067"
       name = "RHEL-8.*HVM*x86_64*GP2"
     }
   }

modules/aws-network-existing/main.tf

@@ -21,3 +21,15 @@ data "aws_subnet" "subnets" {
   for_each = toset(data.aws_subnets.subnet-ids.ids)
   id = each.key
 }
+
+data "aws_subnet" "subnet-by-name" {
+  for_each = toset(var.existing-subnet-names)
+  filter {
+    name   = "tag:Name"
+    values = [each.key]
+  }
+}
+
+data "aws_security_group" "default" {
+  name = var.default-security-group-name
+}

modules/aws-network-existing/outputs.tf

@@ -2,16 +2,25 @@ output "default-vpc" {
   value = data.aws_vpc.default
 }
 
+output "default-sg" {
+  value = data.aws_security_group.default
+}
+
 output "subnets" {
   description = "An array of all subnets in default-vpc."
   value = data.aws_subnet.subnets
 }
 
-output "k8s-subnets" {
+output "one-subnet-per-az" {
-  description = "An array of subnets to be used for k8s VMs. These subnets were chosen by selecting a single subnet from each availability_zone."
+  description = "An array of subnets that selects 1 subnet per az."
   value = [for k,v in local.az-to-subnets : v[0]]
 }
 
+output "subnet-by-name" {
+  description = "A map of subnet name to subnet resource."
+  value = data.aws_subnet.subnet-by-name
+}
+
 output "az-to-subnets" {
   description = "A map of availability zone to array of subnets that are in thet availability zone."
   value = local.az-to-subnets

modules/aws-network-existing/variables.tf

@@ -1,4 +1,13 @@
+variable "default-security-group-name" {
+  description = "The name of the existing default security group. This module will query AWS for a security group with this name,"
+}
+
 variable "default-vpc-name" {
   description = "The name of the existing default VPC. This module will query AWS for a VPC with this name,"
-  default = "Managed VPC"
+}
+
+variable "existing-subnet-names" {
+  description = "A list of subnet names that already exist in default-vpc-name"
+  default     = []
+  type        = list(string)
 }

modules/aws-network/main.tf

@@ -0,0 +1,67 @@
+resource "aws_vpc" "vpc" {
+  cidr_block = var.vpc-cidr-block
+  tags = {
+      Name = "${var.name-prefix}-vpc"
+  }
+}
+
+resource "aws_subnet" "subnet" {
+  vpc_id = aws_vpc.vpc.id
+  cidr_block = var.subnet-cidr-block
+  # availability_zone = var.avail_zone
+  tags = {
+      Name = "${var.name-prefix}-subnet"
+  }
+}
+
+resource "aws_default_security_group" "sg" {
+  vpc_id = aws_vpc.vpc.id
+
+  ingress {
+    from_port   = 22
+    to_port     = 22
+    protocol    = "tcp"
+    cidr_blocks = var.admin-ips
+  }
+
+  egress {
+    from_port       = 0
+    to_port         = 0
+    protocol        = "-1"
+    cidr_blocks     = ["0.0.0.0/0"]
+    prefix_list_ids = []
+  }
+
+  tags = {
+    Name = "${var.name-prefix}-ssh-from-admins-sg"
+  }
+}
+
+resource "aws_internet_gateway" "igw" {
+	vpc_id = aws_vpc.vpc.id
+  tags = {
+    Name = "${var.name-prefix}-igw"
+  }
+}
+
+resource "aws_default_route_table" "route-table" {
+   default_route_table_id = aws_vpc.vpc.main_route_table_id
+
+   route {
+     cidr_block = "0.0.0.0/0"
+     gateway_id = aws_internet_gateway.igw.id
+   }
+
+   # default route, mapping VPC CIDR block to "local", created implicitly and
+   # cannot be specified.
+
+   tags = {
+     Name = "${var.name-prefix}-route-table"
+   }
+}
+
+# Associate subnet with Route Table
+resource "aws_route_table_association" "a-rtb-subnet" {
+  subnet_id      = aws_subnet.subnet.id
+  route_table_id = aws_default_route_table.route-table.id
+}

modules/aws-network/outputs.tf

@@ -0,0 +1,11 @@
+output "vpc" {
+  value = aws_vpc.vpc
+}
+
+output "subnet" {
+  value = aws_subnet.subnet
+}
+
+output "default-security-group" {
+  value = aws_default_security_group.sg
+}

modules/aws-network/variables.tf

@@ -0,0 +1,23 @@
+variable "admin-ips" {
+  description = "A list of ips or cidr blocks that are allowed to connect to the nodes."
+  type = list(string)
+}
+
+variable "name-prefix" {
+  default = "tf"
+  description = "This prefix will be used in all the names of the resources creates in our AWS network."
+  type = string
+}
+
+variable "subnet-cidr-block" {
+  default = "10.0.1.0/24"
+  description = "The address space to be used for this subnet."
+  type = string
+}
+
+variable "vpc-cidr-block" {
+  default = "10.0.0.0/16"
+  description = "The address space to be used for out networks VPC."
+  type = string
+}
+

modules/aws-nodes/main.tf

@@ -1,10 +1,12 @@
 resource "aws_instance" "nodes" {
   ami                         = var.ami
   instance_type               = var.ec2-instance-type
-  # TODO REM double check this key.
+  # TODO Make this a variable.
-  # key_name                    = aws_key_pair.debug1.key_name
   associate_public_ip_address = true
-  subnet_id                   = var.subnet-id
+  subnet_id = element(var.subnet-ids, count.index % length(var.subnet-ids))
+  # Set a private IP if var.private-ips is not empty, otherwise let AWS assign
+  # the IP.
+  private_ip = length(var.private-ips) == 0 ? null : element(var.private-ips, count.index)
   vpc_security_group_ids = var.security-group-ids
   user_data = element(var.user-datas.*.rendered, count.index)
   count                       = var.num-nodes

modules/aws-nodes/outputs.tf

@@ -2,6 +2,14 @@ output "ips" {
   value = aws_instance.nodes.*.public_ip
 }
 
+output "private_ips" {
+  value = aws_instance.nodes.*.private_ip
+}
+
 output "names" {
   value = aws_instance.nodes.*.tags.Name
 }
+
+output "nodes" {
+  value = aws_instance.nodes
+}

modules/aws-nodes/variables.tf

@@ -21,13 +21,19 @@ variable "num-nodes" {
   type = number
 }
 
+variable "private-ips" {
+  default = []
+  description = "A list of private IP addresses to use for the nodes. If the list is empty then each node will get an IP assigned from AWS."
+  type = list(string)
+}
+
 variable "user-datas" {
   description = "A list of cloud-init configs that get applied to their corresponding node."
 }
 
-variable "subnet-id" {
+variable "subnet-ids" {
-  description = "The ID of the subnet that all the nodes will be added to."
+  description = "An array of subnet ids. These subnets will be round robined as the subnet to use for each node."
-  type = string
+  type = list(string)
 }
 
 variable "security-group-ids" {

providers.tf

@@ -1,20 +1,21 @@
 
 provider "aws" {
-  region = "us-gov-west-1"
+  region = var.aws-region
+  # profile = <aws cli profile>
 }
 
 
 terraform {
   required_version = ">= 1.0.8"
 
-    backend "s3" {
+  backend "s3" {
     
-      bucket            = "mss-terraform-state"
+    bucket            = "mss-terraform-state"
-      key               = "global/s3/terraform.tfstate"
+    key               = "global/s3/terraform.tfstate"
-      region            = "us-gov-west-1"
+    region            = "us-gov-west-1"
     
-      dynamodb_table    = "mss-terraform-state-lock"
+    dynamodb_table    = "mss-terraform-state-lock"
-      encrypt           = true
+    encrypt           = true
 
   }
   required_providers {

variables.tf

@@ -1,11 +1,34 @@
 variable "admin-ips" {
+  default = ["0.0.0.0/0"]
   description = "A list of ips or cidr blocks that are allowed to connect to the nodes."
   type = list(string)
 }
 
-variable "aws-ec2-instance-type" {
+variable "aws-zfs-drive-letters" {
-  default = "t2.micro"
+  default     = ["f", "g", "h", "i", "j"]
-  description = "The AWS instance type to use for all nodes."
+  description = "These are the drove letters to use when attaching EBS volumes, ie. /dev/sdf or /dev/sdg"
+  type        = list(string)
+}
+
+variable "aws-existing-sg-name" {
+  default     = "change-me-if-using-aws-network-existing"
+  description = "The name of the existing security group when using aws-network-existing."
+}
+
+variable "aws-existing-vpc-name" {
+  default     = "change-me-if-using-aws-network-existing"
+  description = "The name of the existing VPC when using aws-network-existing."
+}
+
+variable "aws-existing-subnet-names" {
+  description = "A list of subnet names that already exist in aws-existing-vpc-name"
+  default     = []
+  type        = list(string)
+}
+
+variable "aws-proxy-private-ip" {
+  description = "The private IP to request for the proxy instance."
+  type        = string
 }
 
 variable "aws-region" {
@@ -33,6 +56,7 @@ variable "disk-image-pool-name" {
 }
 
 variable "libvirt-connection-url" {
+  default = "nobody@localhost"
   description = "The libvirt connection URI, ie. qemu+ssh://<user>@<host>/system"
 }
 
@@ -89,43 +113,84 @@ variable "vm-name-prefix" {
 
 ################################################################################
 # AWS AMI vars
-# These variables are really mor like constants. Using variables improves
+# These variables are really more like constants. Using variables improves
 # readability. The defaults are manually updated. Use the aws-amis module to get
 # the latest for each distro.
 ################################################################################
 
 variable "amzn2-ami" {
-  default     = "ami-0dd0ccab7e2801812"
+  # us-east-2
+  # default     = "ami-0dd0ccab7e2801812"
+  # us-gov-west-1
+  default     = "ami-098bf51d9a35299f0"
   description = "The AMI to use for Amazon Linux 2."
 }
 variable "ubuntu-ami" {
-  default = "ami-06c7d6c0987eaa46c"
+  # us-east-2
+  # default = "ami-06c7d6c0987eaa46c"
+  # us-gov-west-1
+  default = "ami-087ee83c8de303181"
   description = "The AMI to use for Ubuntu."
 }
 variable "centos7-ami" {
+  # us-east-2
   default = "ami-00f8e2c955f7ffa9b"
   description = "The AMI to use for CentOS 7."
 }
 variable "centos8-ami" {
+  # us-east-2
   default = "ami-057cacbfbbb471bb3"
   description = "The AMI to use for CentOS 8."
 }
 variable "arch-ami" {
+  # us-east-2
   default = "ami-02653f06de985e3ba"
   description = "The AMI to use for Arch Linux."
 }
 variable "rhel7-ami" {
-  default = "ami-0a509b3c2a4d05b3f"
+  # us-east-2
+  # default = "ami-0a509b3c2a4d05b3f"
+  # us-gov-west-1
+  default = "ami-04ccdf5793086ea95"
   description = "The AMI to use for RHEL 7."
 }
 variable "rhel8-ami" {
-  default = "ami-0d871ca8a77af2948"
+  # us-east-2
+  # default = "ami-0d871ca8a77af2948"
+  # us-gov-west-1
+  default = "ami-0b1f10cd1cd107dd2"
   description = "The AMI to use for RHEL 8."
 }
 
+################################################################################
+# AWS EC2 types.
+# These variables are really more like constants. Using variables improves
+# readability.
+################################################################################
+
+variable "t2-micro-1gib-1vcpu" {
+  description = "t2.micro EC2 instance with 1 GiB mem and 1 vCPU."
+  default = "t2.micro"
+}
+
+variable "t2-medium-4gib-2vcpu" {
+  description = "t2.medium EC2 instance with 4 GiB mem and 2 vCPUs."
+  default = "t2.medium"
+}
+
+variable "t2-large-8gib-2vcpu" {
+  description = "t2.large EC2 instance with 8 GiB mem and 2 vCPUs."
+  default = "t2.large"
+}
+
+variable "t2-xlarge-16gib-4vcpu" {
+  description = "t2.xlarge EC2 instance with 16 GiB mem and 4 vCPUs."
+  default = "t2.xlarge"
+}
+
 ################################################################################
 # Libvirt Images
-# These variables are really mor like constants. Using variables improves
+# These variables are really more like constants. Using variables improves
 # readability. The defaults are manually updated.
 ################################################################################